Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUP-1085: Cluster Queue resource implementation #297

Merged
merged 13 commits into from
Jul 4, 2023
Merged

SUP-1085: Cluster Queue resource implementation #297

merged 13 commits into from
Jul 4, 2023

Conversation

james2791
Copy link
Contributor

@james2791 james2791 commented Jun 29, 2023 •
edited
Loading

PR checklist:

  • docs/ updated
  • tests added
  • an example added to examples/ (useful to demo new field/resource)
  • CHANGELOG.md updated with pending release information

Adds the support for creating, updating, deleting, reading and importing Cluster Queue resources.

@mcncl
Copy link
Contributor

mcncl commented Jun 29, 2023

Reviews have been requested but this is in draft, should it be moved to ready for review?

@jradtilbrook jradtilbrook marked this pull request as ready for review June 30, 2023 01:03
@james2791 james2791 marked this pull request as draft June 30, 2023 03:55
jradtilbrook
jradtilbrook suggested changes Jun 30, 2023
View reviewed changes
buildkite/graphql/cluster_queue.graphql Show resolved Hide resolved
buildkite/graphql/cluster_queue.graphql Show resolved Hide resolved
buildkite/resource_cluster_queue.go Outdated Show resolved Hide resolved
docs/resources/cluster_queue.md Outdated Show resolved Hide resolved
@james2791 james2791 requested a review from jradtilbrook July 3, 2023 03:51
@james2791 james2791 marked this pull request as ready for review July 3, 2023 03:51
mcncl
mcncl reviewed Jul 3, 2023
View reviewed changes
buildkite/resource_cluster_queue.go Outdated Show resolved Hide resolved
buildkite/resource_cluster_queue_test.go Outdated Show resolved Hide resolved
@james2791 james2791 requested a review from mcncl July 3, 2023 04:51
@james2791 james2791 requested a review from mcncl July 3, 2023 08:32
mcncl
mcncl previously approved these changes Jul 3, 2023
View reviewed changes
examples/main.tf Show resolved Hide resolved
jradtilbrook
jradtilbrook suggested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@jradtilbrook jradtilbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I just have a request about importing 👇

docs/resources/cluster_queue.md Show resolved Hide resolved
buildkite/resource_cluster_queue.go Show resolved Hide resolved
jradtilbrook
jradtilbrook previously approved these changes Jul 4, 2023
View reviewed changes
@james2791 james2791 merged commit 48931aa into main Jul 4, 2023
@james2791 james2791 deleted the js/SUP-1085-Cluster-Queues branch July 4, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jradtilbrook jradtilbrook jradtilbrook approved these changes

@mcncl mcncl mcncl left review comments

@lizrabuya lizrabuya Awaiting requested review from lizrabuya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james2791 @mcncl @jradtilbrook